-
Notifications
You must be signed in to change notification settings - Fork 96
Fixes PHP 8.4 deprecation warnings #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes the "Implicitly marking parameter $context as nullable is deprecated" deprecation
|
Any downsides will accepting this PR and publishing a new version? |
|
PHP 8.4 adoption is growing, so it would be nice to have support for it, @cebe . I obviously have the same issue with PHP 8.5 as well. |
|
Maybe if you don’t have time (which is totally understandable, since you’re spending your free time on open source), you could add another maintainer to help? There seems to be many open PR's and Issues. |
|
Another maintainer would be better than a fork. If B/C is an issue, what about releasing a 2.0 with only PHP 8.4+ and the latest of the libraries? A quick rector pass would also make the code more maintainable because static analysis is so much better with the later versions. |
|
@cebe is there anything we could do here to help you? or to help maintain the repo? PHP 8.4 als ready the most installed version currently, see => https://packagist.org/php-statistics |
|
@tacman i have published this fork, if you need this fixed: https://github.com/nadar/cebe-php-openapi/releases/tag/1.0 replace |
Fixes the "Implicitly marking parameter ... as nullable is deprecated" deprecation warnings